Skip to content

use in instead string join #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

lunny
Copy link
Member

@lunny lunny commented Nov 12, 2016

No description provided.

@codecov-io
Copy link

codecov-io commented Nov 12, 2016

Current coverage is 3.03% (diff: 0.00%)

Merging #155 into master will not change coverage

@@            master      #155   diff @@
========================================
  Files           33        33          
  Lines         8100      8100          
  Methods          0         0          
  Messages         0         0          
  Branches         0         0          
========================================
  Hits           246       246          
  Misses        7834      7834          
  Partials        20        20          

Powered by Codecov. Last update 555d8b1...08ba0ba

@tboerger tboerger added the type/enhancement An improvement of existing functionality label Nov 12, 2016
@tboerger tboerger added this to the 1.0.0 milestone Nov 12, 2016
@tboerger
Copy link
Member

LGTM

1 similar comment
@thibaultmeyer
Copy link
Contributor

LGTM

@thibaultmeyer thibaultmeyer merged commit 30a3731 into go-gitea:master Nov 12, 2016
@tboerger tboerger added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Nov 29, 2016
@lunny lunny deleted the lunny/use_in_instead_string_join branch April 19, 2017 05:41
ethantkoenig pushed a commit to ethantkoenig/gitea that referenced this pull request Apr 29, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants