Follow-up #15546 - test for ErrObjectNotExist#15583
Merged
Merged
Conversation
go-gitea#15546 doesn't completely fix this problem because the error returned is an ObjectNotExist error not a BranchNotExist error. Fix go-gitea#15257 Signed-off-by: Andrew Thornton <art27@cantab.net>
lunny
approved these changes
Apr 22, 2021
GiteaBot
added
the
lgtm/need 1
6543
approved these changes
Apr 22, 2021
GiteaBot
added
lgtm/done
Member
|
🚀 |
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Apr 22, 2021
…exing (follow-up of go-gitea#15546) (go-gitea#15583) Backport go-gitea#15546 Backport go-gitea#15583 go-gitea#15546 doesn't completely fix this problem because the error returned is an ObjectNotExist error not a BranchNotExist error. Add test for ErrObjectNotExist too Fix go-gitea#15257 Signed-off-by: Andrew Thornton <art27@cantab.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#15546 doesn't completely fix this problem because the error returned is an ObjectNotExist
error not a BranchNotExist error.
Fix #15257
Signed-off-by: Andrew Thornton art27@cantab.net