Resolve panic on failed interface conversion in migration v156#15604
Merged
Conversation
go panics otherwise with `panic: interface conversion: error is git.ErrNotExist, not *git.ErrNotExist`, thanks to Codeberg/Andi for reporting this.
jolheiser
approved these changes
Apr 23, 2021
GiteaBot
added
the
lgtm/need 1
lunny
approved these changes
Apr 24, 2021
GiteaBot
added
lgtm/done
Codecov Report
@@ Coverage Diff @@
## master #15604 +/- ##
==========================================
+ Coverage 43.88% 43.92% +0.04%
==========================================
Files 678 678
Lines 81742 81742
==========================================
+ Hits 35874 35907 +33
+ Misses 40014 39985 -29
+ Partials 5854 5850 -4
Continue to review full report at Codecov.
|
Member
|
Please send backport |
techknowlogick
added a commit
to techknowlogick/gitea
that referenced
this pull request
Apr 24, 2021
…tea#15604) go panics otherwise with `panic: interface conversion: error is git.ErrNotExist, not *git.ErrNotExist`, thanks to Codeberg/Andi for reporting this. Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
techknowlogick
added
the
backport/done
techknowlogick
added a commit
that referenced
this pull request
Apr 25, 2021
… (#15610) go panics otherwise with `panic: interface conversion: error is git.ErrNotExist, not *git.ErrNotExist`, thanks to Codeberg/Andi for reporting this. Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go panics otherwise with
panic: interface conversion: error is git.ErrNotExist, not *git.ErrNotExist, thanks to Codeberg/Andi for reporting this.