Refactor of link creation#15619
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15619 +/- ##
==========================================
+ Coverage 43.92% 43.93% +0.01%
==========================================
Files 678 678
Lines 81741 81743 +2
==========================================
+ Hits 35905 35915 +10
+ Misses 39984 39977 -7
+ Partials 5852 5851 -1
Continue to review full report at Codecov.
|
Member
|
I would like we use |
Member
Author
Do you have some methods in mind? After a short look I think only my new |
zeripath
approved these changes
Apr 26, 2021
6543
approved these changes
Apr 30, 2021
Member
|
🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced repetitive code with the specific methods.