Defer closing the gitrepo until the end of the wrapped context functions#15653
Merged
6543 merged 5 commits intoMay 5, 2021
Merged
Conversation
There was a mistake in go-gitea#15372 where deferral of gitrepo close occurs before it should. This PR fixes this. Signed-off-by: Andrew Thornton <art27@cantab.net>
Codecov Report
@@ Coverage Diff @@
## master #15653 +/- ##
==========================================
- Coverage 43.89% 43.89% -0.01%
==========================================
Files 678 678
Lines 81868 81898 +30
==========================================
+ Hits 35933 35946 +13
- Misses 40086 40101 +15
- Partials 5849 5851 +2
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
lunny
reviewed
Apr 29, 2021
silverwind
approved these changes
May 5, 2021
GiteaBot
added
lgtm/need 1
6543
approved these changes
May 5, 2021
GiteaBot
added
lgtm/done
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
May 6, 2021
…ons (go-gitea#15653) Backport go-gitea#15653 There was a mistake in go-gitea#15372 where deferral of gitrepo close occurs before it should. This PR fixes this. Signed-off-by: Andrew Thornton <art27@cantab.net>
12 tasks
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 10, 2021
…ons (go-gitea#15653) There was a mistake in go-gitea#15372 where deferral of gitrepo close occurs before it should. This PR fixes this. Signed-off-by: Andrew Thornton <art27@cantab.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a mistake in #15372 where deferral of gitrepo close occurs before it should.
This PR fixes this.
Signed-off-by: Andrew Thornton art27@cantab.net