Implement delete release attachments and update release attachments' name (#14130)#15666
Merged
techknowlogick merged 3 commits intoMay 3, 2021
Merged
Conversation
…name (go-gitea#14130) * Implement delete release attachment * Add attachments on release edit page * Fix bug * Finish del release attachments * Fix frontend lint * Fix tests * Support edit release attachments * Added tests * Remove the unnecessary parameter isCreate from UpdateReleaseOrCreatReleaseFromTag * Rename UpdateReleaseOrCreatReleaseFromTag to UpdateRelease * Fix middle align
Contributor
|
Not sure about this - it's technically a feature - but I know we tend to have relatively slow turnarounds for 1.15 |
GiteaBot
added
the
lgtm/need 2
Contributor
Author
Understood - I'm perfectly happy either way. We should be diligent on not adding breaking changes & new features. The reason I thought this might be appropriate is:
If you're uncomfortable with it, lets close this and work on |
Member
|
Since there is no migration and break thing, I think it's OK. |
6 tasks
6543
approved these changes
May 2, 2021
GiteaBot
added
lgtm/need 1
Member
|
@kdumontnu can you update the branch please :) |
zeripath
approved these changes
May 3, 2021
GiteaBot
added
lgtm/done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #14130
fix #677
Co-authored-by: lunny