Add Location, Website and Description to API#15675
Merged
Merged
Conversation
6543
approved these changes
Apr 30, 2021
GiteaBot
added
the
lgtm/need 1
Contributor
|
I think we need to consider this slightly more carefully. I don't think we need to always return this data. |
Member
|
well it's public on your profile page & optional so I think there is no issue |
zeripath
approved these changes
Apr 30, 2021
Contributor
zeripath
left a comment
zeripath
left a comment
There was a problem hiding this comment.
Still doesn't appear that these can be easily set by the API though
GiteaBot
added
lgtm/done
Member
|
@KN4CK3R would you mind to extend user edit api or do you like to put this into a new pull? |
Member
Author
|
I will change the edit api too. |
Codecov Report
@@ Coverage Diff @@
## master #15675 +/- ##
==========================================
- Coverage 43.92% 43.90% -0.03%
==========================================
Files 678 678
Lines 81741 81809 +68
==========================================
+ Hits 35905 35916 +11
- Misses 39984 40045 +61
+ Partials 5852 5848 -4
Continue to review full report at Codecov.
|
Merged
6543
changed the title
6543
pushed a commit
that referenced
this pull request
May 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #14248