Fix setting redis db path#15698
Merged
techknowlogick merged 2 commits intoMay 3, 2021
Merged
Conversation
There is a bug setting the redis db in the common nosql manager whereby the db path always fails. This PR fixes this. Signed-off-by: Andrew Thornton <art27@cantab.net>
Contributor
Author
|
Unfortunately a unit test for this isn't really possible without substantial refactor. |
GiteaBot
added
the
lgtm/need 2
Codecov Report
@@ Coverage Diff @@
## master #15698 +/- ##
==========================================
+ Coverage 43.90% 43.93% +0.02%
==========================================
Files 678 678
Lines 81827 81827
==========================================
+ Hits 35926 35948 +22
+ Misses 40051 40030 -21
+ Partials 5850 5849 -1
Continue to review full report at Codecov.
|
Closed
6 tasks
techknowlogick
approved these changes
May 1, 2021
GiteaBot
added
lgtm/need 1
KN4CK3R
approved these changes
May 3, 2021
GiteaBot
added
lgtm/done
Member
|
🚀 |
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
May 3, 2021
Backport go-gitea#15698 There is a bug setting the redis db in the common nosql manager whereby the db path always fails. This PR fixes this. Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added a commit
that referenced
this pull request
May 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a bug setting the redis db in the common nosql manager whereby the db path
always fails.
This PR fixes this.
Fix #15680
Signed-off-by: Andrew Thornton art27@cantab.net