Skip to content

Fix close button change on delete in simplemde area #15737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zeripath merged 3 commits into from
May 5, 2021
Merged

Fix close button change on delete in simplemde area #15737

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b4bb3b9
Fix close button change on delete in simplemde area
zeripath May 5, 2021
7fbedd2
apply suggestion
6543 May 5, 2021
cd767f8
Merge branch 'main' into fix-comment-and-close-issue
6543 May 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions web_src/js/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1184,6 +1184,12 @@ async function initRepository() {
// Change status
const $statusButton = $('#status-button');
$('#comment-form textarea').on('keyup', function () {
const $simplemde = $(this).data('simplemde');
if ($simplemde && $simplemde.value().length !== 0) {
$statusButton.text($statusButton.data('status-and-comment'));
return;
}

Comment thread
6543 marked this conversation as resolved.
Outdated
if ($(this).val().length === 0) {
$statusButton.text($statusButton.data('status'));
} else {
Expand Down Expand Up @@ -1698,6 +1704,8 @@ function setCommentSimpleMDE($editArea) {
}
});
attachTribute(simplemde.codemirror.getInputField(), {mentions: true, emoji: true});
$editArea.data('simplemde', simplemde);
$(simplemde.codemirror.getInputField()).data('simplemde', simplemde);
return simplemde;
}

Expand Down