Fix bound address/port for caddy's certmagic library#15758
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #15758 +/- ##
==========================================
- Coverage 43.93% 43.93% -0.01%
==========================================
Files 678 678
Lines 81945 81950 +5
==========================================
- Hits 36005 36004 -1
- Misses 40069 40075 +6
Partials 5871 5871
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
Contributor
|
the thing is certmagic shouldn't be opening any ports itself. We open and control these ports ourselves. |
6543
previously requested changes
May 7, 2021
Member
6543
left a comment
6543
left a comment
There was a problem hiding this comment.
as per zeripath, we should find out why certmagic would (if ..) open a port itself and consider it a bug
zeripath
approved these changes
May 9, 2021
Contributor
zeripath
left a comment
zeripath
left a comment
There was a problem hiding this comment.
the ListenHost and AltHTTPPort are used in the challenge solvers - that's why they're needed
GiteaBot
added
lgtm/need 1
techknowlogick
approved these changes
May 12, 2021
GiteaBot
added
lgtm/done
6543
approved these changes
May 12, 2021
Contributor
|
make lgtm work |
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
May 12, 2021
Backport go-gitea#15758 * Fix bound address/port for caddy's certmagic library * Fix bug Co-authored-by: zeripath <art27@cantab.net>
zeripath
added a commit
that referenced
this pull request
May 12, 2021
Merged
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 10, 2021
* Fix bound address/port for caddy's certmagic library * Fix bug Co-authored-by: zeripath <art27@cantab.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my attempt to fix issue created by d2ea21d when switching to Caddy's certmagic library. I believe that the call to
ManageSynccauses Gitea to try and listen on port 80 even ifPortToRedirectis set.Please test this fix, but I think it works. Thoughts?