Run processors on whole of text#16155
Merged
zeripath merged 5 commits intoJun 17, 2021
Merged
Conversation
There is an inefficiency in the design of our processors which means that Emoji and other processors run in order n^2 time. This PR forces the emoji processors to process the entirety of text node before passing back up. The fundamental inefficiency remains but it should be significantly ameliorated. Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added
type/bug
performance/speed
Member
|
It's better to add a benchmark. |
GiteaBot
added
the
lgtm/need 2
Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
force-pushed
the
run-emoji-processor-on-whole-of-data
branch
from
480c3c1 to
c17207d
Compare
zeripath
changed the title
Contributor
Author
|
Benchmark added. |
6543
approved these changes
Jun 16, 2021
Member
6543
left a comment
6543
left a comment
There was a problem hiding this comment.
142208659396 ns/op -> 1195548 ns/op
GiteaBot
added
lgtm/need 1
Contributor
Author
|
Things can be further improved by not having the processors reprocess text that they have already seen - i.e. track the next sibling and don't do anything till that happens. However that would require more changes to the processor. |
Member
|
@zeripath this pull as is can be backported ... refactor should be done later :) |
Codecov Report
@@ Coverage Diff @@
## main #16155 +/- ##
==========================================
+ Coverage 44.57% 44.60% +0.03%
==========================================
Files 699 700 +1
Lines 82794 82925 +131
==========================================
+ Hits 36906 36990 +84
- Misses 39906 39946 +40
- Partials 5982 5989 +7
Continue to review full report at Codecov.
|
khmarbaise
approved these changes
Jun 17, 2021
GiteaBot
added
lgtm/done
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Jun 17, 2021
Backport go-gitea#16155 There is an inefficiency in the design of our processors which means that Emoji and other processors run in order n^2 time. This PR forces the processors to process the entirety of text node before passing back up. The fundamental inefficiency remains but it should be significantly ameliorated. Signed-off-by: Andrew Thornton <art27@cantab.net>
6543
pushed a commit
that referenced
this pull request
Jun 17, 2021
Backport #16155 There is an inefficiency in the design of our processors which means that Emoji and other processors run in order n^2 time. This PR forces the processors to process the entirety of text node before passing back up. The fundamental inefficiency remains but it should be significantly ameliorated. Signed-off-by: Andrew Thornton <art27@cantab.net>
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 10, 2021
There is an inefficiency in the design of our processors which means that Emoji and other processors run in order n^2 time. This PR forces the processors to process the entirety of text node before passing back up. The fundamental inefficiency remains but it should be significantly ameliorated. Signed-off-by: Andrew Thornton <art27@cantab.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an inefficiency in the design of our processors which means that Emoji
and other processors run in order n^2 time.
This PR forces all of the processors to process the entirety of text node before passing
back up. The fundamental inefficiency remains but it should be significantly
ameliorated.
Signed-off-by: Andrew Thornton art27@cantab.net