Fix wrong reference that was causing #16336#16338
Closed
moqmar wants to merge 2 commits into
Closed
Conversation
node.Attr[idx].Val is not the same as attr.Val, the latter is an independent object that won't change anything in the document
Contributor
Author
|
Disclaimer: I have no idea what issue the second change that I made might fix, or which new issues it might introduce. The code was last updated in zeripath@55c3e48, and originally introduced in zeripath@9de1eb0. Maybe @zeripath knows if that was intentional? |
GiteaBot
added
the
lgtm/need 2
Member
|
I think #16340 just do it |
Member
|
@moqmar thanks for digging into and the pull. Since it's already fixed an CI on your pull fail. ill close it. Feel free to reopen if you think there is more to look at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
node.Attr[idx].Val is not the same as attr.Val, the latter is an independent object that won't change anything in the document. This fixes #16336, the issue was introduced in #16118.