Add Cache-Control to avatar redirects#16973
Merged
Merged
Conversation
This does seem to do the trick to make the Avatar redirects cachable in Chrome. In Firefox, it does not seem to work, thought and I found no way to suppress the requests to the original URLs, I even tried setting an Etag to no avail. Related discussion in go-gitea#16964.
6 tasks
zeripath
approved these changes
Sep 6, 2021
Contributor
zeripath
left a comment
zeripath
left a comment
There was a problem hiding this comment.
small nit but otherwise lgtm
GiteaBot
added
the
lgtm/need 1
axifive
approved these changes
Sep 6, 2021
GiteaBot
added
lgtm/done
zeripath
reviewed
Sep 6, 2021
6543
approved these changes
Sep 6, 2021
Contributor
|
The default A user won't see his new avatar in 6 hours if he did a change ...... maybe he will submit a new issue saying "avatars not changed" Is it good for end users? |
Member
Author
|
We could shorten the default time a bit. Gravatar and GitHub use 5 minutes, for example. |
Contributor
it appears to work in my firefox (just a standard firefox developer edition) 🎉 |
Member
Author
|
Nice. In my testing I could not get Firefox to cache the redirect for whatever reason, even tried a completely fresh profile. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does seem to do the trick to make the Avatar redirects cachable in Chrome.
In Firefox, it does not seem to work, thought and I found no way to suppress the requests to the original URLs, I even tried setting 301 or an Etag to no avail.
Related discussion in #16964.