Skip to content

Make TestOneDevDownloadRepo work again & more resistant #16987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 8, 2021
Merged

Make TestOneDevDownloadRepo work again & more resistant #16987

merged 2 commits into from
Sep 8, 2021

Conversation

6543
Copy link
Member

@6543 6543 commented Sep 8, 2021

No description provided.

@6543 6543 added type/testing skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Sep 8, 2021
@6543 6543 added this to the 1.16.0 milestone Sep 8, 2021
@6543 6543 changed the title Make OneDev migration unit tests work again Make TestOneDevDownloadRepo work again & more resistant Sep 8, 2021
@KN4CK3R
Copy link
Member

KN4CK3R commented Sep 8, 2021

It's a mistake that the OneDev tests still use the "normal" assert.EqualValues methods. I added a PR which provides multiple assert methods in https://github.com/go-gitea/gitea/blob/main/modules/migrations/main_test.go for the tests. All other providers use these methods, so OneDev should too. Then you don't have to worry about the time fields.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 8, 2021
@6543 6543 force-pushed the make-OneDev-test-work-again branch from 0535c33 to f060c92 Compare September 8, 2021 13:25
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 8, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 8, 2021
@6543 6543 merged commit f55cd03 into go-gitea:main Sep 8, 2021
@6543 6543 deleted the make-OneDev-test-work-again branch September 8, 2021 14:17
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@KN4CK3R KN4CK3R KN4CK3R approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/testing
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.
4 participants
@6543 @KN4CK3R @zeripath @GiteaBot