Move db related basic functions to models/db#17075
Merged
Merged
Conversation
c870928 to
43f4e97
Compare
KN4CK3R
reviewed
Sep 18, 2021
KN4CK3R
reviewed
Sep 18, 2021
Codecov Report
@@ Coverage Diff @@
## main #17075 +/- ##
==========================================
+ Coverage 45.24% 45.25% +0.01%
==========================================
Files 771 773 +2
Lines 86767 86828 +61
==========================================
+ Hits 39255 39292 +37
- Misses 41160 41181 +21
- Partials 6352 6355 +3
Continue to review full report at Codecov.
|
zeripath
approved these changes
Sep 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
modelsbecomes more and more big, splitting it becomes a task to refactor.This PR create a new subpackage
models/dband move common database functions to that package.The next PRs should create business logic related subpackages of
modelsand move related codes there. i.e. Moving allmodels/issue*.gotomodels/issues/.