Prevent NPE on invalid diff - #17197
Merged
Merged
Conversation
If ParseCompareInfo returns a nil compare info the defer function needs to ensure that it does not attempt to close the HeadGitRepo. Fix go-gitea#17193 Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added
type/bug
issue/regression
6543
approved these changes
Sep 30, 2021
GiteaBot
added
the
lgtm/need 1
jolheiser
approved these changes
Sep 30, 2021
6543
reviewed
Sep 30, 2021
6543
approved these changes
Sep 30, 2021
6543
force-pushed
the
prevent-npe-17193
branch
from
September 30, 2021 16:58
c7c6022 to
2fc02b2
Compare
KN4CK3R
approved these changes
Sep 30, 2021
GiteaBot
added
lgtm/done
Member
|
lgtm likes me 🙂 |
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Oct 15, 2021
* Prevent NPE on invalid diff If ParseCompareInfo returns a nil compare info the defer function needs to ensure that it does not attempt to close the HeadGitRepo. Fix go-gitea#17193 Signed-off-by: Andrew Thornton <art27@cantab.net> * add TEST Co-authored-by: 6543 <6543@obermui.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If ParseCompareInfo returns a nil compare info the defer function needs to ensure
that it does not attempt to close the HeadGitRepo.
Fix #17193
Regression #16635
Signed-off-by: Andrew Thornton art27@cantab.net