Rename db Engines related functions#17481
Merged
Merged
Conversation
lunny
added
the
type/refactoring
Codecov Report
@@ Coverage Diff @@
## main #17481 +/- ##
=======================================
Coverage 45.47% 45.47%
=======================================
Files 791 791
Lines 88697 88702 +5
=======================================
+ Hits 40335 40339 +4
+ Misses 41850 41845 -5
- Partials 6512 6518 +6
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
Contributor
|
I like the idea to make these function names clear. |
lunny
force-pushed
the
lunny/rename_db_engines
branch
from
October 29, 2021 11:45
09e39bf to
da11426
Compare
wxiaoguang
approved these changes
Oct 29, 2021
wxiaoguang
reviewed
Oct 29, 2021
GiteaBot
added
lgtm/need 1
delvh
approved these changes
Oct 29, 2021
GiteaBot
added
lgtm/done
lunny
force-pushed
the
lunny/rename_db_engines
branch
from
October 30, 2021 03:55
ec3d3ce to
b305ba2
Compare
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
* Rename db Engines related functions Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To make it not confusing, this PR renamed some functions related database Engine.
GetNewEngine->NewEngine: this function will return axorm.Engineas the first return parameter, so call itNewis suitable.SetEngine->InitEngine: it will call the originalGetNewEngineand assign engine to thedbpackage variablex. So we call itInit.NewEngine->InitEngineWithMigration: the function will callSetEnginewith some migration functions.NewInstallTestEngine->InitInstallEngineWithMigration: the function will callSetEnginewith sometestspecial statements.