When the git repository on storage is changed, the repository modal should also be updated #18088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxiaoguang
force-pushed
the
fix-repo-empty
branch
from
ec99096 to
cb8b524
Compare
…hould also be updated.
wxiaoguang
force-pushed
the
fix-repo-empty
branch
from
cb8b524 to
d3888f8
Compare
Codecov Report
@@ Coverage Diff @@
## main #18088 +/- ##
=======================================
Coverage ? 44.89%
=======================================
Files ? 824
Lines ? 91575
Branches ? 0
=======================================
Hits ? 41114
Misses ? 43861
Partials ? 6600
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
|
TBH the IsEmpty flag is deeply broken and should be removed with the UI changed to manage to cope with empty repos. For example it's possible for a repository to be non-empty by that flag but still 500 because there are no branches - only tags -or the default branch is non-extant as it has been 0-pushed. |
zeripath
approved these changes
Dec 24, 2021
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Dec 24, 2021
GiteaBot
added
lgtm/done
That's very helpful. I added more comments there. |
wxiaoguang
force-pushed
the
fix-repo-empty
branch
from
d89310a to
f6ebf80
Compare
7 tasks
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
…hould also be updated (go-gitea#18088) User would keep seeing an empty repo if: * An error occurs during the first git pushing/receiving * A user replaces the Gitea's empty repository manually Fix: when a user is viewing the repository web page, if the repoModal.IsEmpty is true, we check the git repository again to detect whether it is really empty. However: the IsEmpty flag is deeply broken and should be removed. For example it's possible for a repository to be non-empty by that flag but still 500 because there are no branches - only tags -or the default branch is non-extant as it has been 0-pushed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw some issues about "after pushing the git repository to Gitea, the Gitea web still shows the repository is empty" (I can not remember the issue number now ....)
And I meet the same problem today. This problem would be caused by some cases:
The reason behind the problem is that the
repoModal.IsEmptyis out of sync of the real status of the repo.This PR fixes the problem. When a user is viewing the repository web page, if the
repoModal.IsEmptyis true, we check the git repository again to detect whether it is really empty.This PR was tested on my side, and I can view the non-empty git repository correctly now.
Maybe we should fix more inconsistent data, please help to review and suggest, thank you