Set default AppVer for main branch #18146
Conversation
|
please see discussion in regards to this line here: #9916 |
GiteaBot
added
the
lgtm/need 2
How to resolve the problem described in #18124 (#18124 (review)) ? If we do not set AppVer globally, then it would appear in many unit tests. |
| @@ -27,7 +27,7 @@ import ( | |||
|
|
|||
| var ( | |||
| // Version holds the current Gitea version | |||
| Version = "development" | |||
| Version = "1.16.9999+dev-main" | |||
There was a problem hiding this comment.
So to dismantle this:
1.16
Gitea's version
.9999
Uhm.... minor patch is quite high. Guess this is the indication that it's built from development?
+dev-main
IIRC it should be -dev+main. But I'm not sure about the +main part as that is mostly used for build metadata, or something along those lines. Otherwise this could be used as indication that it's development built and then leave the minor patch alone.
There was a problem hiding this comment.
.9999: because the main branch is always newer than any released version. So I choose the impossible version number 9999. Even during update check, the Gitea 1.16.9999 in development won't tell developers that "there is a new version 1.16.8 available".
+dev-main: it comes from the current Gitea version format, for exmpale, on try.gitea.io: 1.16.0+dev-782-gde8e3948a. And yes, maybe we do not need the last main, we could use 1.16.9999+dev or 1.16.9999+dev-local instead.
There was a problem hiding this comment.
In that sense I think we can use +dev-local.
|
I'll "fix" the sdk ... please not this again ... |
I propose to always have a valid AppVer in code base, and we should bump it for every major release.
For example, in this PR:
The gitea-sdk expects to get a valid AppVer from server response, and the gitea-sdk also have some version-depended behaviors.