Skip to content

Allow to filter repositories by language in explore, user and organization repositories lists - #18430

Merged
lafriks merged 2 commits into
go-gitea:mainfrom
lafriks-fork:feat/lang_filter
Jan 28, 2022
Merged

lafriks merged 2 commits into
go-gitea:mainfrom
lafriks-fork:feat/lang_filter

Conversation

@lafriks

@lafriks lafriks commented Jan 27, 2022

Copy link
Copy Markdown
Member

Allow to filter by primary language in following repository lists:

  • Explore repositories
  • Organization repository list
  • User repository list
  • User starred repositories
  • User watched repositories

To search by language user can click on language tag in repository list

@lafriks lafriks added the type/enhancement An improvement of existing functionality label Jan 27, 2022
@lafriks lafriks added this to the 1.17.0 milestone Jan 27, 2022

@Gusted Gusted left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, maybe at a later point it's possible to add a separate UI/Menu to select the language based off the languages that's currently in the search results(kind of like github currently does).

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 27, 2022
@lafriks

lafriks commented Jan 27, 2022

Copy link
Copy Markdown
Member Author

In code search we already do that just like GitHub does (showing languages that are for files in search results). Functionality implemented here is not available in GitHub at all. Closest to this is trending repositories where you can select language.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 28, 2022
@Gusted

Gusted commented Jan 28, 2022 •

Copy link
Copy Markdown
Contributor

In code search we already do that just like GitHub does (showing languages that are for files in search results). Functionality implemented here is not available in GitHub at all. Closest to this is trending repositories where you can select language.

Sorry, I meant a menu like(sorted by the count of repo's that uses a certain language):

image

@lafriks

lafriks commented Jan 28, 2022

Copy link
Copy Markdown
Member Author

I could not find such filter, in what page is it in GitHub? But yes this could be added in the future

@Gusted

Gusted commented Jan 28, 2022

Copy link
Copy Markdown
Contributor

https://github.com/search?q=gitea

@lafriks
lafriks merged commit 604ce77 into go-gitea:main Jan 28, 2022
@lafriks
lafriks deleted the feat/lang_filter branch January 28, 2022 11:29
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jan 28, 2022
* 'main' of https://github.com/go-gitea/gitea:
  Allow to filter repositories by language in explore, user and organization repositories lists (go-gitea#18430)
  Fix broken when no commits and default branch is not master (go-gitea#18422)
  [skip ci] Updated translations via Crowdin
  Automatically pause queue if index service is unavailable (go-gitea#15066)
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants