Warn at startup if the provided SCRIPT_TYPE is not on the PATH#18467
Merged
zeripath merged 1 commit intoJan 30, 2022
Conversation
Several users run Gitea in situations whereby `bash` is not available. If the `SCRIPT_TYPE` is not changed this will cause hooks to fail. A simple test to check if the provided type is on the PATH should be sufficient to warn them about this problem. Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
force-pushed
the
warn-invalid-script-type-on-startup
branch
from
1fd1368 to
4217764
Compare
Gusted
approved these changes
Jan 30, 2022
GiteaBot
added
the
lgtm/need 1
lunny
approved these changes
Jan 30, 2022
Contributor
Author
|
make lgtm work |
GiteaBot
added
lgtm/done
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
…gitea#18467) Several users run Gitea in situations whereby `bash` is not available. If the `SCRIPT_TYPE` is not changed this will cause hooks to fail. A simple test to check if the provided type is on the PATH should be sufficient to warn them about this problem. Signed-off-by: Andrew Thornton <art27@cantab.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several users run Gitea in situations whereby
bashis not available.If the
SCRIPT_TYPEis not changed this will cause hooks to fail.A simple test to check if the provided type is on the PATH should be
sufficient to warn them about this problem.
Signed-off-by: Andrew Thornton art27@cantab.net