Prevent 500 when there is an error during new auth source post

[zeripath]

Fix #19036

Signed-off-by: Andrew Thornton art27@cantab.net

[lunny]

Have you checked all the places in that templates?

[wxiaoguang]

There is another bug reported in #19036 (Error 1062: Duplicate entry 'aa' for key 'login_source.UQE_login_source_name)

Steps:

1. Create login source "foo"
2. Create login source "bar"
3. Edit "bar", change the name to "foo", save
4. Then 500 error occurs because duplicated unique key.

I didn't know what's the proper way to handle the duplicated key check in Gitea. Should it use a separate SELECT to check? Or does XORM provide some error check mechanism to detect the error is caused by duplicated unique key?

[6543]

👍

[lunny]

There is another bug reported in #19036 (Error 1062: Duplicate entry 'aa' for key 'login_source.UQE_login_source_name)

Steps:

1. Create login source "foo"
2. Create login source "bar"
3. Edit "bar", change the name to "foo", save
4. Then 500 error occurs because duplicated unique key.

I didn't know what's the proper way to handle the duplicated key check in Gitea. Should it use a separate SELECT to check? Or does XORM provide some error check mechanism to detect the error is caused by duplicated unique key?

Please create a new issue.