Use full output of git show-ref --tags to get tags for PushUpdateAddTag (#19235)#19236
Merged
Merged
Conversation
zeripath
added
type/bug
topic/repo-migration
zeripath
force-pushed
the
backport-19235-v1.16
branch
from
a9a2ccd to
128fcd5
Compare
6543
force-pushed
the
backport-19235-v1.16
branch
from
9a5f031 to
010cc8e
Compare
…ag (go-gitea#19235) Strangely go-gitea#19038 appears to relate to an issue whereby a tag appears to be listed in `git show-ref --tags` but then does not appear when `git show-ref --tags -- short_name` is called. As a solution though I propose to stop the second call as it is unnecessary and only likely to cause problems. I've also noticed that the tags calls are wildly inefficient and aren't using the common cat-files - so these have been added. I've also noticed that the git commit-graph is not being written on mirroring - so I've also added writing this to the migration which should improve mirror rendering somewhat. Fix go-gitea#19038 Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: 6543 <6543@obermui.de>
6543
force-pushed
the
backport-19235-v1.16
branch
from
010cc8e to
fba252b
Compare
6543
approved these changes
Mar 29, 2022
GiteaBot
added
the
lgtm/need 1
Member
|
@zeripath cherry-picked the latest state and force pushed ... |
Contributor
Author
|
Thanks @6543 |
lafriks
approved these changes
Mar 29, 2022
GiteaBot
added
lgtm/done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #19235
Strangely #19038 appears to relate to an issue whereby a tag appears to
be listed in
git show-ref --tagsbut then does not appear whengit show-ref --tags -- short_nameis called.As a solution though I propose to stop the second call as it is
unnecessary and only likely to cause problems.
Fix #19038
Signed-off-by: Andrew Thornton art27@cantab.net