Revert the minimal golang version requirement from 1.17 to 1.16 and add a warning in Makefile#19319
Conversation
…dd a warning in Makefile
lunny
added
the
topic/build
GiteaBot
added
the
lgtm/need 1
GiteaBot
added
lgtm/done
Co-authored-by: John Olheiser <john.olheiser@gmail.com>
| @if [ "$(GO_VERSION)" -lt "$(MIN_GO_VERSION)" ]; then \ | ||
| echo "Gitea requires Go $(MIN_GO_VERSION_STR) or greater to build. You can get it at https://go.dev/dl/"; \ | ||
| echo "Gitea requires Go $(MIN_GO_VERSION_STR) or greater to build, but $(GO_VERSION) was found. You can get an updated version at https://go.dev/dl/"; \ | ||
| exit 1; \ | ||
| else \ | ||
| echo "WARNING: Please ensure Go $(GO_VERSION_STR) is still maintained to avoid possible security problems. You can check it at https://go.dev/dl/"; \ |
There was a problem hiding this comment.
Isn't it very strange for a user who uses Go1.18 see this WARNING?
There was a problem hiding this comment.
Currently yes, but when Golang go to 1.2x, it will not.
There was a problem hiding this comment.
I think if we leave this, we can expect other issues with why this warning is appearing for users that are using the latest go version. We don't want to let them think that they are using a outdated go version when they are not.
There was a problem hiding this comment.
But we will never know it except we check Golang's website in the Makefile.
|
This actually won't build in 1.16 as this PR is now, due this file f9ea4ab#diff-93c289a98a6bd37986878061f982fad85e37b47dff818559e021216f9319a2a8 I will push changes to this branch to resolve before merging. |
Co-authored-by: Gusted <williamzijl7@hotmail.com>
yay tests for catching this :)
7 participants
Fix #19187