Disable service worker by default (#18914)#19342
Merged
Merged
Conversation
The service worker causes a lot of issues with JS errors after instance upgrades while not bringing any real performance gain over regular HTTP caching. Disable it by default for this reason. Maybe later we can remove it completely, as I simply see no benefit in having it.
Member
|
This will only have effect on new installations and users that have that field left unconfigured. Perhaps a mention in the release notes should be in order? |
GiteaBot
added
the
lgtm/need 2
Member
Author
|
I think generally, we should be able to expect users to not have copy-pasted the example config as-is so unless they willingly set this option, they should rely on the default. But yes, a note could be added to further reinforce that this is essentially a bugfix and we suggest to disable it in all cases for production setups. |
wxiaoguang
approved these changes
Apr 7, 2022
Contributor
wxiaoguang
left a comment
wxiaoguang
left a comment
There was a problem hiding this comment.
Since it's useless, I think we can just set UI.UseServiceWorker=false
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Apr 7, 2022
GiteaBot
added
lgtm/done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #18914 to 1.16 as requested in #19341 (comment). It's a harmless change that should fix a lot browser cache issues. Later on, I plan to remove the ServiceWorker entirely.