Use for a repo action one database transaction#19576
Merged
Merged
Conversation
6543
added
pr/wip
lunny
reviewed
May 2, 2022
GiteaBot
added
the
lgtm/need 2
wxiaoguang
reviewed
May 2, 2022
Member
Author
|
|
Co-authored-by: delvh <dev.lh@web.de>
Member
Author
|
tip use |
Member
Author
|
@wxiaoguang I did the merge into a db.WithTx() ... so the scope of the transaction now should be clear :) |
wxiaoguang
approved these changes
May 3, 2022
Contributor
wxiaoguang
left a comment
wxiaoguang
left a comment
There was a problem hiding this comment.
It seems that err = db.WithTx(...); if err != nil {} could be easier to read than if db.WithTx(....) != nil { } when the func code are very long.
GiteaBot
added
lgtm/need 1
lunny
approved these changes
May 3, 2022
GiteaBot
removed
the
lgtm/need 1
GiteaBot
added
the
lgtm/done
Contributor
|
@6543 do you have plan to use If yes, let's wait for the change. |
Member
Author
it has to do something with how notification package is handled
Member
Author
|
next deadlock: |
…e merge infoce internal api that cant handle open db sessions to the same repo
Member
Author
|
🚀 |
Member
Author
|
-> #19596 ... |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
May 4, 2022
* giteaofficial/main: Fix broken TR on cherrypick page (go-gitea#19599) Use correct context in `routers/web` (go-gitea#19597) Use for a repo action one database transaction (go-gitea#19576) Only set CanColorStdout / CanColorStderr to true if the stdout/stderr is a terminal (go-gitea#19581) Don't fetch Mirror when it's migrating (go-gitea#19588) Move user password verification after checking his groups on ldap auth (go-gitea#19587)
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 24, 2022
... more context (part of go-gitea#9307)
zeripath
reviewed
Oct 8, 2022
|
|
||
| pr.MergedCommitID, err = rawMerge(ctx, pr, doer, mergeStyle, expectedHeadCommitID, message) | ||
| // TODO: make it able to do this in a database session | ||
| mergeCtx := context.Background() |
Contributor
There was a problem hiding this comment.
We should NEVER use context.Background()!
zeripath
reviewed
Oct 26, 2022
Comment on lines
+509
to
+510
| // TODO: this cause an api call to "/api/internal/hook/post-receive/...", | ||
| // that prevents us from doint the whole merge in one db transaction |
Contributor
There was a problem hiding this comment.
If you know that you don't want our hooks to run you could have used the InternalPushingEnvironment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... more context
(part of #9307)