Remove RequireHighlightJS field, update plantuml example.#19615
Merged
Conversation
wxiaoguang
added
topic/ui
wxiaoguang
force-pushed
the
remove-requirehighlightjs
branch
from
f384f0f to
7807cd7
Compare
lunny
approved these changes
May 5, 2022
GiteaBot
added
the
lgtm/need 1
lafriks
approved these changes
May 5, 2022
GiteaBot
added
lgtm/done
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
May 5, 2022
* giteaofficial/main: Call MultipartForm.RemoveAll when request finishes (go-gitea#19606) Remove `RequireHighlightJS` field, update plantuml example. (go-gitea#19615) [skip ci] Updated translations via Crowdin PullService lock via pullID (go-gitea#19520)
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
RequireHighlightJSdoesn't work well, and it should be removed. It has been obsolete for a long time (since #17365)Frontend code should use other methods (eg: check
'.language-plantuml') to load external JS renders. Fix #19110(ps: the code of
plantuml_codeblock_parse.jsis not modularized, but that's another story)The
RequireHighlightJSis removed from template data, you should not use it anymore.