Skip to content

Don't reload action.Repo when it has been loaded #19632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from

Conversation

lunny
Copy link
Member

@lunny lunny commented May 6, 2022

Improvement for #19598

@Gusted Gusted added this to the 1.17.0 milestone May 8, 2022
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 8, 2022
@lunny lunny force-pushed the lunny/performance_improve branch from e7db788 to 33318f3 Compare May 8, 2022 08:39
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 8, 2022
@lunny lunny force-pushed the lunny/performance_improve branch from 6c7b571 to 4a45c71 Compare May 8, 2022 16:20
@zeripath
Copy link
Contributor

zeripath commented May 8, 2022

hmm... I think we might be better off changing the SELECT so as to not extract any of the repo fields from the db in the first place: There's likely to be a duplication of a lot of repo data this could cause a significant increase in memory use.

(TBH we should be extracting the last update time from the repo and using caching to get a copy of the latest version.)

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@d483407). Click here to learn what that means.
The diff coverage is 91.66%.

@@           Coverage Diff           @@
##             main   #19632   +/-   ##
=======================================
  Coverage        ?   47.36%           
=======================================
  Files           ?      957           
  Lines           ?   133415           
  Branches        ?        0           
=======================================
  Hits            ?    63196           
  Misses          ?    62587           
  Partials        ?     7632           
Impacted Files Coverage Δ
models/action.go 49.24% <85.71%> (ø)
models/action_list.go 64.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d483407...4a45c71. Read the comment docs.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label May 9, 2022
@lunny lunny closed this May 9, 2022
@lunny lunny deleted the lunny/performance_improve branch May 9, 2022 13:43
@lunny lunny removed this from the 1.17.0 milestone May 9, 2022
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 1 This PR needs approval from one additional maintainer to be merged. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants