-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Fix missed alpine version #19667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missed alpine version #19667
Conversation
Wasn't the alpine bump meant for 1.17 only because of breaking changes related to older versions of the docker daemon? In any case, |
Did you mean the minial golang version to compile Gitea? It's still go1.17 but unrelated with this change to docker building. |
No, see discussion in #18050. Alpine 3.15 is breaking because it requires docker engine > 20.10.6. |
We need a decision. Building a possible non-security image or ask user upgrade their docker version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm for forcing them to upgrade - or they can also run a total insecure setup as a whole ...
tldr: why should we force users to use an insecure base image either? |
We don't Alpine 3.13 is not EOL https://endoflife.date/alpine |
@lunny shouldn't we target main instead ?!? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that would require a majour version bump ... - and the next majour release is not too far away
I think an alternative would be to apk install the specific packages that need to be upgraded from a later version of alpine. |
Normally, distro vendors would backport security fixes so this should not be necessary. Or is this not the case for Alpine? |
@silverwind they mean EOL as it sounds https://alpinelinux.org/releases/ so sec issues are backported but it's mostly relay on the package maintainers & asap it's eol they wont get merged |
Looks like it's |
replaced by #19876 |
No description provided.