Skip to content

Pr hook branch info #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

kmadel
Copy link
Contributor

@kmadel kmadel commented Nov 19, 2016

Please check the following:

  1. Make sure you are targeting the master branch.
  2. Read contributing guidelines:
    https://github.com/go-gitea/gitea/blob/master/CONTRIBUTING.md
  3. Describe what your pull request does and which issue
    you're targeting (if any)

You MUST delete above content including this line before posting;
too lazy to take this action considered invalid pull request.

@codecov-io
Copy link

Current coverage is 3.03% (diff: 0.00%)

Merging #197 into master will decrease coverage by <.01%

@@            master      #197   diff @@
========================================
  Files           33        33          
  Lines         8106      8110     +4   
  Methods          0         0          
  Messages         0         0          
  Branches         0         0          
========================================
  Hits           246       246          
- Misses        7840      7844     +4   
  Partials        20        20          

Powered by Codecov. Last update cf045b0...bf5d76c

@andreynering andreynering added the type/enhancement An improvement of existing functionality label Nov 19, 2016
@strk
Copy link
Member

strk commented Nov 19, 2016

It looks like you missed the too lazy to take this action message ...

@lunny lunny added this to the 1.0.0 milestone Nov 20, 2016
@lunny
Copy link
Member

lunny commented Nov 21, 2016

LGTM

@strk
Copy link
Member

strk commented Nov 22, 2016

LGTM isn't working, still counts 0/2 while there @lunny one -- if these tools aren't stable we should consider dropping their use

@kmadel
Copy link
Contributor Author

kmadel commented Nov 22, 2016

This was a PR from GoGits that was asked to be pushed here as well - I will update when I get a chance. If someone needs it sooner, by all means take it.

@bkcsoft
Copy link
Member

bkcsoft commented Nov 23, 2016

@kmadel I have a working branch for this (and more) that needs migration to Gitea anyways so I'll hijack this one 🙂

@tboerger tboerger added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Nov 23, 2016
@tboerger
Copy link
Member

@bkcsoft so what happens to it?

@bkcsoft
Copy link
Member

bkcsoft commented Nov 25, 2016

New PR here: #248

@lunny lunny removed this from the 1.0.0 milestone Nov 25, 2016
@lunny
Copy link
Member

lunny commented Nov 25, 2016

So this one could be closed?

@tboerger
Copy link
Member

Yep, since it's done by @bkcsoft we should close this PR.

@tboerger tboerger closed this Nov 25, 2016
@tboerger tboerger added issue/duplicate The issue has already been reported. lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed type/enhancement An improvement of existing functionality lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. labels Nov 25, 2016
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/duplicate The issue has already been reported.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants