Improved ref comment link when origin is body/title#19741
Merged
Conversation
… "" in RefCommentHTMLURL()
delvh
approved these changes
May 18, 2022
GiteaBot
added
the
lgtm/need 1
Co-authored-by: delvh <dev.lh@web.de>
6543
approved these changes
May 18, 2022
GiteaBot
added
lgtm/done
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
May 19, 2022
* giteaofficial/main: Update base.go (go-gitea#19739) [doctor] do not update User Stars numbers unless --fix (go-gitea#19750) Fix incorrect translation key (go-gitea#19744) Improved ref comment link when origin is body/title (go-gitea#19741) [doctor] explain what enable-push-options does (go-gitea#19740)
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 24, 2022
* Makes comments in body text/title return the base page URL instead of "" in RefCommentHTMLURL() * Add comment explaining branch Co-authored-by: delvh <dev.lh@web.de>
delvh
added
topic/ui-interaction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comments with references use
RefCommentHTMLURL()to fetch the URL location to link to.However for references originating in body text or titles, this falls back to a value of
"".This means that when a reference comes from a body/title, the link just reloads the current page, which is weird.
This PR changes the fallback behaviour to return the URL of the originating issue/PR. This way if the body text of
pulls/Xlinks to an issue, then the cross ref comment will link to 'pulls/X'.There are no other references to
RefCommentHTMLURL()in the codebase so I don't think this has any risk.