Adjust transaction handling via db.Context#20031
Merged
6543 merged 4 commits intogo-gitea:mainfrom Jun 20, 2022
Merged
Conversation
lunny
added
the
type/refactoring
delvh
reviewed
Jun 19, 2022
| } | ||
|
|
||
| // InTransaction if context is in a transaction | ||
| func (ctx *Context) InTransaction() bool { |
Member
There was a problem hiding this comment.
What exactly is the purpose of this method?
It seems currently unused.
And also, when would that be good to know?
Member
Author
There was a problem hiding this comment.
It's a requirement from #19513 , I think there are some requirements in some place but previously there is no suitable function to use.
GiteaBot
added
the
lgtm/need 2
Member
|
please resolve conflicts |
Member
Author
resolved. |
delvh
approved these changes
Jun 20, 2022
Member
delvh
left a comment
delvh
left a comment
There was a problem hiding this comment.
So, to recap:
You opened a PR titled "Adjust something", and when asked where this something is needed, the answer boils down to "somewhere, perhaps".
No further questions. LGTM.
GiteaBot
added
lgtm/need 1
6543
approved these changes
Jun 20, 2022
GiteaBot
added
lgtm/done
6543
changed the title
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jun 21, 2022
* giteaofficial/main: [skip ci] Updated translations via Crowdin Catch the error before the response is processed by goth. (go-gitea#20000) Adjust transaction handling via db.Context (go-gitea#20031) Add more linters to improve code readability (go-gitea#19989) [skip ci] Updated translations via Crowdin Disable federation by default (go-gitea#20045) Respond with a 401 on git push when password isn't changed yet (go-gitea#20026) Alter hook_task TEXT fields to LONGTEXT (go-gitea#20038) Simplify and fix migration 216 (go-gitea#20035) use quoted regexp instead of git fixed-value (go-gitea#20029) fix delete pull head ref for DeleteIssue (go-gitea#20032) User keypairs and HTTP signatures for ActivityPub federation using go-ap (go-gitea#19133) Backtick table name in generic orphan check (go-gitea#20019) Update document to clarify that ALLOWED_DOMAINS/BLOCKED_DOMAINS support wildcard (go-gitea#20016) Return 404 when tag is broken (go-gitea#20017) Dump should only copy regular files and symlink regular files (go-gitea#20015)
vsysoev
pushed a commit
to IntegraSDL/gitea
that referenced
this pull request
Aug 10, 2022
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially fix #19513