Skip to content

update git module to fix bugs in fact #2031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

lunny
Copy link
Member

@lunny lunny commented Jun 22, 2017

As title.

@lunny lunny added the type/bug label Jun 22, 2017
@lunny lunny added this to the 1.2.0 milestone Jun 22, 2017
@lafriks
Copy link
Member

lafriks commented Jun 22, 2017

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 22, 2017
@cez81
Copy link
Contributor

cez81 commented Jun 22, 2017

LGTM

@cez81
Copy link
Contributor

cez81 commented Jun 22, 2017

make L-G-T-M work

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 22, 2017
@sapk
Copy link
Member

sapk commented Jun 22, 2017

@lunny have you updated the repo from a windows os ? I suspect that hash are not the same between linux and windows. (related #1888)

@lunny
Copy link
Member Author

lunny commented Jun 22, 2017

I updated the repo on macOS Sierra.

@cez81
Copy link
Contributor

cez81 commented Jun 22, 2017

I tried updating too and hash on Ubuntu is Ju4zZF8u/DPrZYEEY40rogh3hyQ=.

@sapk
Copy link
Member

sapk commented Jun 22, 2017

Same here (on archlinux with latest govendor) :

{
-                       "checksumSHA1": "Ve00iavGUw8bQmDeXuEJ51wEk40=",
+                       "checksumSHA1": "Ju4zZF8u/DPrZYEEY40rogh3hyQ=",
                        "path": "code.gitea.io/git",        
-                       "revision": "a34a13dea30c0d242c5256cc321b48f8041ce095",
-                       "revisionTime": "2017-06-20T02:08:21Z"
+                       "revision": "51eca9e92242b93a0510edd19f1db6fc11ca1028",
+                       "revisionTime": "2017-06-21T01:06:07Z"
}

@sapk
Copy link
Member

sapk commented Jun 22, 2017

It seems that there is some inconsistency with the checksumSHA1 in govendor based on platform and mostly because of EOL difference between os.

@lafriks lafriks mentioned this pull request Jun 22, 2017
@lafriks
Copy link
Member

lafriks commented Jun 22, 2017

I have created new one #2037 that should be correct

@lunny lunny closed this Jun 23, 2017
@lunny lunny removed this from the 1.2.0 milestone Jun 23, 2017
@lunny lunny deleted the lunny/update_git branch June 23, 2017 01:32
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants