Add write check for creating Commit status (#20332)#20334
Merged
Conversation
Contributor
Gusted
commented
Jul 12, 2022
Gusted
commented
- Backport Add write check for creating Commit status #20332
- Add write code checks for creating new commit status
- Regression from Restrict permission check on repositories and fix some problems #5314
- Resolves New commit status API doesn't check permissions properly #20331
- Backport go-gitea#20332 - Add write code checks for creating new commit status - Regression from go-gitea#5314 - Resolves go-gitea#20331
Gusted
added
type/bug
issue/regression
zeripath
approved these changes
Jul 12, 2022
GiteaBot
added
the
lgtm/need 1
KN4CK3R
approved these changes
Jul 12, 2022
GiteaBot
added
lgtm/done
6543
approved these changes
Jul 12, 2022
6543
added
the
topic/security
freebsd-git
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Aug 5, 2022
- Add write check for creating Commit status go-gitea/gitea#20334 - Check for permission when fetching user controlled issues go-gitea/gitea#20196 PR: 265526
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.