fix: Actor is required to get user repositories

[dhruvmanila]

fixes: #20442

[silverwind]

redacting review for now.

[6543]

what we could do to not have a panic but an error:

check for actor == nil and if so return an error.New("Actor is needed but not given")

[dhruvmanila]

So, the panic was thrown because instead of passing in the user model directly through the Actor field, it's passing the id through the OwnerId field:

gitea/services/user/user.go

Lines 71 to 78 in 7690de5

	repos, _, err := repo_model.GetUserRepositories(&repo_model.SearchRepoOptions{
	ListOptions: db.ListOptions{
	PageSize: repo_model.RepositoryListDefaultPageSize,
	Page: 1,
	},
	Private: true,
	OwnerID: u.ID,
	})

As per the reviews, I think 2 changes need to be done:

1. Pass in the user model directly through the Actor option
2. Return an error if Actor is not given (as suggested by @6543)

[zeripath]

I have a feeling we should change repo_model.GetUserRepositories to use OwnerID and not Actor to list the UserRepositories. However, this does fix the bug.

I apologise for merging the PR with this bug - it is due to a mismerge.

[zeripath]

I've added a test case too

[zeripath]

Doesn't need backporting as far as I'm aware as purging hasn't been backported

[6543]

🚀