Skip to content

Make the vscode clone link respect transport protocol #20557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
techknowlogick merged 14 commits into from
Sep 9, 2022
+6 −1
Merged

Make the vscode clone link respect transport protocol #20557

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
913b67f
change vscode clone link to ssh
noerw Jul 30, 2022
61c0cd3
Merge remote-tracking branch 'upstream/main' into vscode-ssh
noerw Aug 1, 2022
836a777
adjust to new clone button script
noerw Aug 1, 2022
57472de
refactor: less inlining
noerw Aug 1, 2022
7ab76a4
refactor: use separate class
noerw Aug 1, 2022
cbbc830
fix syntax typo
noerw Aug 1, 2022
fae64bf
firefox doesnt like this `` literal??
noerw Aug 1, 2022
09fb67f
re-add default value for use without JS
noerw Aug 1, 2022
a9d1c27
Merge remote-tracking branch 'upstream/main' into vscode-ssh
noerw Aug 1, 2022
e1d141e
Merge commit d26b6522 into vscode-ssh-2
monim67 Aug 26, 2022
0cb637b
Merge pull request #1 from monim67/vscode-ssh-2
noerw Sep 8, 2022
c76f599
Merge branch 'main' into vscode-ssh
techknowlogick Sep 9, 2022
c614111
Apply suggestions from code review
wxiaoguang Sep 9, 2022
2fd33d1
Merge branch 'main' into vscode-ssh
lunny Sep 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion templates/repo/clone_script.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
<script>
// synchronously set clone button states and urls here to avoid flickering
// on page load. initRepoCloneLink calls this when proto changes.
// this applies the protocol-dependant clone url to all elements with the
// `js-clone-url` and `js-clone-url-vs` classes.
Comment thread
wxiaoguang marked this conversation as resolved.
Outdated
// TODO: This localStorage setting should be moved to backend user config
// so it's available during rendering, then this inline script can be removed.
(window.updateCloneStates = function() {
Expand All @@ -17,7 +19,11 @@

const link = btn.getAttribute('data-link');
for (const el of document.getElementsByClassName('js-clone-url')) {
el[el.nodeName === 'INPUT' ? 'value' : 'textContent'] = link;
const attr = (el.nodeName === 'INPUT') ? 'value' : 'textContent';
el[attr] = link;
Comment thread
wxiaoguang marked this conversation as resolved.
Outdated
}
for (const el of document.getElementsByClassName('js-clone-url-vs')) {
Comment thread
wxiaoguang marked this conversation as resolved.
Outdated
el['href'] = 'vscode://vscode.git/clone?url=' + encodeURIComponent(link);
}
})();
</script>
2 changes: 1 addition & 1 deletion templates/repo/home.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@
<a class="item archive-link" href="{{$.RepoLink}}/archive/{{PathEscapeSegments $.BranchName}}.tar.gz" rel="nofollow">{{svg "octicon-file-zip" 16 "mr-3"}}{{.locale.Tr "repo.download_tar"}}</a>
<a class="item archive-link" href="{{$.RepoLink}}/archive/{{PathEscapeSegments $.BranchName}}.bundle" rel="nofollow">{{svg "octicon-package" 16 "mr-3"}}{{.locale.Tr "repo.download_bundle"}}</a>
{{end}}
<a class="item" href="vscode://vscode.git/clone?url={{$.RepoCloneLink.HTTPS}}">{{svg "gitea-vscode" 16 "mr-3"}}{{.locale.Tr "repo.clone_in_vsc"}}</a>
<a class="item js-clone-url-vs" href="vscode://vscode.git/clone?url={{.CloneButtonOriginLink.HTTPS}}">{{svg "gitea-vscode" 16 "mr-3"}}{{.locale.Tr "repo.clone_in_vsc"}}</a>
Comment thread
wxiaoguang marked this conversation as resolved.
Outdated
</div>
</button>
</div>
Expand Down