Improve arc-green code theme (#21039)#21042
Merged
Merged
Conversation
silverwind
added
type/enhancement
6543
approved these changes
Sep 3, 2022
GiteaBot
added
the
lgtm/need 1
Member
|
? |
Member
|
|
Member
I just want to help to change the base branch but found I cannot so I revert my change. Maybe @silverwind could rebase himself. |
- Increase contrasts overall - Add various missing theme classes - Ensure strings and constants are colored the same across languages Before: <img width="575" alt="Screen Shot 2022-09-03 at 15 20 19" src="https://user-images.githubusercontent.com/115237/188272267-c3af3de0-a1d9-4a80-a3ab-278e9b04cb44.png"> <img width="705" alt="Screen Shot 2022-09-03 at 15 10 12" src="https://user-images.githubusercontent.com/115237/188272194-dc40ac7d-1629-44a0-a881-5f0922285195.png"> After: <img width="579" alt="Screen Shot 2022-09-03 at 15 19 31" src="https://user-images.githubusercontent.com/115237/188272275-55b87bc7-1122-410f-9250-14cf9e973124.png"> <img width="703" alt="image" src="https://user-images.githubusercontent.com/115237/188272715-a5fcd180-c5dc-4303-8e77-de785d5e0937.png">
6543
approved these changes
Sep 3, 2022
Member
6543
left a comment
6543
left a comment
There was a problem hiding this comment.
didn't noticed wrong targeting branch first as pull diff was right 😆
Member
|
fixed ;) |
Member
Author
|
Thanks for the branch fixes, looks good now I think. |
lunny
approved these changes
Sep 3, 2022
GiteaBot
added
lgtm/done
delvh
approved these changes
Sep 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #21039
Before:
After:
