Create a lock abstract layer and remove old one #22176
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
the
type/refactoring
|
Need to run |
GiteaBot
added
the
lgtm/need 2
The error is returned argument hasn't been handled. |
KN4CK3R
reviewed
Dec 21, 2022
lunny
changed the title
Resolved. |
|
Build error is related. |
This comment was marked as off-topic.
This comment was marked as off-topic.
KN4CK3R
reviewed
Jan 1, 2023
Co-authored-by: Yarden Shoham <[email protected]>
KN4CK3R
reviewed
Jan 10, 2023
KN4CK3R
reviewed
Jan 10, 2023
wxiaoguang
requested changes
Jan 10, 2023
There was a problem hiding this comment.
Just a brief review, I think there are some bugs and some designs are wrong.
- Old
StartIfNotRunningwon't block if it can not acquire the lock, it's incorrect to replace it directly byLock - In
TransferOwnership, the same lock is locked twice without unlocking the previous lock - The Redis lock behavior is totally different from the internal lock. Redis lock will return error in 8 seconds if the lock can not be acquired, it might break the old logic -- which expects the lock can be acquired in the end without error.
viceice
reviewed
May 3, 2023
| ## Sync (`sync`) | ||
|
|
||
| - `LOCK_SERVICE_TYPE`: **memory**: Lock service type, could be `memory` or `redis` | ||
| - `LOCK_SERVICE_CONN_STR`: **\<empty\>**: Ignored when `LOCK_SERVICE_TYPE` is `memory` type, for `redis`, it likes `addrs=127.0.0.1:6379 db=0` |
There was a problem hiding this comment.
shouldn't this use the same connection string format which the other redis types are using?
GiteaBot
added
lgtm/blocked
|
Please follow #26486 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduce an abstract lock layer. For a single instance, just use
memorylock which is default value. For a multiple instances deployment, change to a distributed lock based onredis.Try to fix ##19620