Fix assignment to cm.AssigneeID when importing comments#22528
Merged
techknowlogick merged 1 commit intogo-gitea:mainfrom Jan 19, 2023
Merged
Fix assignment to cm.AssigneeID when importing comments#22528techknowlogick merged 1 commit intogo-gitea:mainfrom
cm.AssigneeID when importing comments#22528techknowlogick merged 1 commit intogo-gitea:mainfrom
Conversation
This is a fix for go-gitea#22510 The code assumed that the `AssigneeID` from the comment YAML was an `int64`, but it is actually an `int`, causing a panic. It also had no check on whether the type cast was actually valid, so badly formatted YAML could also cause a panic. Both these issues have been fixed.
jolheiser
added
type/bug
skip-changelog
jolheiser
approved these changes
Jan 19, 2023
GiteaBot
added
the
lgtm/need 1
techknowlogick
approved these changes
Jan 19, 2023
GiteaBot
added
lgtm/done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for #22510
The code assumed that the
AssigneeIDfrom the comment YAML was anint64, but it is actually anint, causing a panic. It also had no check on whether the type cast was actually valid, so badly formatted YAML could also cause a panic.Both these issues have been fixed.