Skip to content

Fix cache-control header clearing comment text when editing issue #22604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jolheiser merged 4 commits into from
Feb 1, 2023
Merged

Fix cache-control header clearing comment text when editing issue #22604

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
790705b
Fix cache-control header clearing comment text when editing issue
brechtvl Jan 26, 2023
299a85f
Merge branch 'main' into fix-comment-lost-on-reload
lunny Jan 31, 2023
ed3728a
Merge branch 'main' into fix-comment-lost-on-reload
lunny Jan 31, 2023
b6f3880
Merge branch 'main' into fix-comment-lost-on-reload
jolheiser Feb 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions modules/httpcache/httpcache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,12 @@ func AddCacheControlToHeader(h http.Header, maxAge time.Duration, additionalDire

if setting.IsProd {
if maxAge == 0 {
directives = append(directives, "no-store")
directives = append(directives, "max-age=0", "private", "must-revalidate")
} else {
directives = append(directives, "private", "max-age="+strconv.Itoa(int(maxAge.Seconds())))
}
} else {
directives = append(directives, "no-store")
directives = append(directives, "max-age=0", "private", "must-revalidate")

// to remind users they are using non-prod setting.
h.Add("X-Gitea-Debug", "RUN_MODE="+setting.RunMode)
Expand Down