support search issues pagination #22704
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techknowlogick
added
type/enhancement
techknowlogick
approved these changes
Feb 25, 2023
GiteaBot
added
the
lgtm/need 1
delvh
reviewed
Mar 10, 2023
Comment on lines
+192
to
+199
| // this api is also used in UI, | ||
| // so the default limit is set to fit UI needs | ||
| limit := ctx.FormInt("limit") | ||
| if limit == 0 { | ||
| limit = setting.UI.IssuePagingNum | ||
| } else if limit > setting.API.MaxResponseItems { | ||
| limit = setting.API.MaxResponseItems | ||
| } |
There was a problem hiding this comment.
🤨
Sounds like a bug report waiting to happen.
There was a problem hiding this comment.
These lines just moved from line 222 - 230
| if filteredCount, err = issues_model.CountIssues(ctx, issuesOpt); err != nil { | ||
| ctx.Error(http.StatusInternalServerError, "CountIssues", err) | ||
| return | ||
| if filteredCount == 0 { |
There was a problem hiding this comment.
Under what circumstances is filteredCount 0 and why should we return the total number of issues then?
Can't we just delete this whole branch now?
Comment on lines
+485
to
+492
| if filteredCount == 0 { | ||
| issuesOpt.ListOptions = db.ListOptions{ | ||
| Page: -1, | ||
| } | ||
| if filteredCount, err = issues_model.CountIssues(ctx, issuesOpt); err != nil { | ||
| ctx.Error(http.StatusInternalServerError, "CountIssues", err) | ||
| return | ||
| } |
| @@ -2341,13 +2342,22 @@ func SearchIssues(ctx *context.Context) { | |||
| var issues []*issues_model.Issue | |||
| var filteredCount int64 | |||
|
|
|||
| // this api is also used in UI, | |||
| if filteredCount, err = issues_model.CountIssues(ctx, issuesOpt); err != nil { | ||
| ctx.Error(http.StatusInternalServerError, "CountIssues", err.Error()) | ||
| return | ||
| if filteredCount == 0 { |
| if filteredCount, err = issues_model.CountIssues(ctx, issuesOpt); err != nil { | ||
| ctx.Error(http.StatusInternalServerError, err.Error()) | ||
| return | ||
| if filteredCount == 0 { |
|
Stale? |
|
After finished this PR, I realize we should not support pagination for a search engine. The next page maybe better. |
|
For anyone coming to this PR in the future as in the linked issue, this PR is not suitable for pagination due to other issues. |
|
I'm writing a new PR which will replace this one and try to fix #24662 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds pagination support to search results, next PR will include template changes to allow for UI to utilize this pagination.