Skip to content

Use native error checking with exec.ErrDot #22735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 3, 2023
Merged

Use native error checking with exec.ErrDot #22735

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4096442
Use native error checking with `exec.ErrDot`
yardenshoham Feb 3, 2023
86d1132
Merge branch 'main' into use-go1.19-error
yardenshoham Feb 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions modules/setting/setting.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ package setting

import (
"encoding/base64"
"errors"
"fmt"
"math"
"net"
Expand Down Expand Up @@ -466,8 +467,7 @@ func getAppPath() (string, error) {
}

if err != nil {
// FIXME: Once we switch to go 1.19 use !errors.Is(err, exec.ErrDot)
if !strings.Contains(err.Error(), "cannot run executable found relative to current directory") {
if !errors.Is(err, exec.ErrDot) {
return "", err
}
appPath, err = filepath.Abs(os.Args[0])
Expand Down