change org_type.go to visible_type.go and fix the notes#22752
Merged
Conversation
lunny
approved these changes
Feb 4, 2023
GiteaBot
added
the
lgtm/need 1
techknowlogick
approved these changes
Feb 8, 2023
GiteaBot
added
lgtm/done
techknowlogick
added
the
skip-changelog
lunny
added
the
reviewed/wait-merge
Contributor
|
Make lgtm work |
lunny
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Feb 9, 2023
* upstream/main: change org_type.go to visible_type.go and fix the notes (go-gitea#22752) Improve notification and stopwatch styles (go-gitea#22169) Fix blame view missing lines (go-gitea#22826) Load issue before accessing index in merge message (go-gitea#22822) include build info in Prometheus metrics (go-gitea#22819) Fix rerun button of Actions (go-gitea#22798) Map OIDC groups to Orgs/Teams (go-gitea#21441) Fix links for the menus in the view file page (go-gitea#22795)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems
VisibleTypeis only designed for org at first. But it is also used by user's visibility now.So I think
org_type.gocan be changed tovisible_type.go.