Allow both fullname and username search when DEFAULT_SHOW_FULL_NAME is true

[HesterG]

This PR adds the ability to search both fullname and username for assignees, reviewers and author search boxes when the config DEFAULT_SHOW_FULL_NAME in app.ini is set to true. Which is originally raised here
And if DEFAULT_SHOW_FULL_NAME is set to false(default value), these search boxes will only show username.

Example:
When DEFAULT_SHOW_FULL_NAME = true

When DEFAULT_SHOW_FULL_NAME = false (default value)

The specific search boxes that adapts these changes include:

1. Author, Assignee search boxes in pull requests tab and issues tab in repository

2. Assigee and Author on milestones issue page (Added missing search box for author here)

3. Assignee on issues and PR Sidebar, Reviewer on PR Sidebar

4. Assignee when creating new issue

5. Whitelisted users for pushing, Whitelisted users for merging and Whitelisted reviewers in Protected branch settings

6. "Allowed users" in tags settings

[wxiaoguang]

Is it possible to have a GetFullDisplayName, make it prepare and return everything according to DefaultShowFullName ?

Then:

• GetFullDisplayName: show username (if no display name) or username (User Name)
• GetDisplayName: only show User Name

[HesterG]

Is it possible to have a GetFullDisplayName, make it prepare and return everything according to DefaultShowFullName ?

Then:

• GetFullDisplayName: show username (if no display name) or username (User Name)
• GetDisplayName: only show User Name

Currently logic for GetDisplayName is to return full name if it's not empty and DEFAULT_SHOW_FULL_NAME is set, and it is used in many places, so might not change it to return User Name.
And for the GetFullDisplayName idea, also thought about this before, but i found it hard to get everything prepared because the html might be different depending on the search box. Or do you mean something else?

[wxiaoguang]

And for the GetFullDisplayName idea, also thought about this before, but i found it hard to get everything prepared because the html might be different depending on the search box. Or do you mean something else?

Does something like <span user-nane>username<span user-full-name>User Name</span></span> work? If no, ignore my comment.

[HesterG]

And for the GetFullDisplayName idea, also thought about this before, but i found it hard to get everything prepared because the html might be different depending on the search box. Or do you mean something else?

Does something like <span user-nane>username<span user-full-name>User Name</span></span> work? If no, ignore my comment.

Yes i found it works. I misunderstood the search input box structure before, let me add a function to return this from backend.

[HesterG]

Added a commit to use GetSearchNameHTML instead of passing contexts, and this PR is ready for review again.

[HesterG]

LGTM. And please resolve the conflicts.

resolved

[jolheiser]

🎺 🤖