Fix JS error on compare page (#23551)#23566
Merged
Merged
Conversation
Fix regression from go-gitea#23271. This code apparently runs on the compare page where there is no review button so check for existance of both button and content. <img width="1226" alt="Screenshot 2023-03-17 at 21 42 47" src="https://user-images.githubusercontent.com/115237/226040001-ec097edd-d926-4c80-9962-526f9b7eff19.png"> Fixes go-gitea#23562
GiteaBot
added
type/bug
topic/ui
delvh
approved these changes
Mar 18, 2023
GiteaBot
added
the
lgtm/need 1
silverwind
approved these changes
Mar 18, 2023
GiteaBot
added
lgtm/done
delvh
added
the
reviewed/wait-merge
yardenshoham
approved these changes
Mar 18, 2023
delvh
removed
the
reviewed/wait-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #23551 by @silverwind
Fix regression from #23271. This code apparently runs on the compare page where there is no review button so check for existance of both button and content.
Fixes #23562