Skip to content

Add actions support to package auth verification #23729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lunny merged 20 commits into from
Apr 10, 2023
Merged

Add actions support to package auth verification #23729

Changes from 4 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
ce230ec
fix
yp05327 Mar 27, 2023
78b383a
improve
yp05327 Mar 27, 2023
f86ac6f
Update routers/api/packages/container/auth.go
yp05327 Mar 27, 2023
b12b1c9
use GetPossibleUserByID instead of GetUserByID
yp05327 Mar 27, 2023
ad0b2c2
fix
yp05327 Mar 27, 2023
953a248
fix
yp05327 Mar 27, 2023
5789917
Merge branch 'main' into fix-gitea-action-docker-login
lunny Mar 27, 2023
b95d72f
check triggeruser's permission
yp05327 Mar 28, 2023
60abfe8
improve permission check
yp05327 Mar 28, 2023
4b4026b
fix lint
yp05327 Mar 28, 2023
b04e219
add return
yp05327 Mar 28, 2023
1e2b185
remove unneccesary line
yp05327 Mar 28, 2023
9520c12
fix
yp05327 Apr 3, 2023
1144abe
revert improve permission check
yp05327 Apr 3, 2023
6236266
revert add LoadTriggerUser
yp05327 Apr 3, 2023
59c7997
remove todo
yp05327 Apr 3, 2023
f4f605b
Merge branch 'main' into fix-gitea-action-docker-login
KN4CK3R Apr 9, 2023
398f32a
Merge branch 'main' into fix-gitea-action-docker-login
lunny Apr 9, 2023
13c4163
Merge branch 'main' into fix-gitea-action-docker-login
lunny Apr 10, 2023
2da1b0c
Merge branch 'main' into fix-gitea-action-docker-login
lunny Apr 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions routers/api/packages/container/auth.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,7 @@ func (a *Auth) Verify(req *http.Request, w http.ResponseWriter, store auth.DataS
return nil, err
}

if uid == 0 {
return nil, nil
}
if uid == -1 {
return user_model.NewGhostUser(), nil
}

u, err := user_model.GetUserByID(req.Context(), uid)
u, err := user_model.GetPossibleUserByID(req.Context(), uid)
if err != nil {
log.Error("GetUserByID: %v", err)
return nil, err
Expand Down