Remove incorrect HTML self close tag#23748
Merged
Merged
Conversation
wxiaoguang
changed the title
silverwind
approved these changes
Mar 27, 2023
GiteaBot
added
the
lgtm/need 1
KN4CK3R
approved these changes
Mar 27, 2023
GiteaBot
added
lgtm/done
lunny
added
reviewed/wait-merge
Member
|
🚀 |
KN4CK3R
removed
the
reviewed/wait-merge
delvh
reviewed
Mar 27, 2023
Member
delvh
left a comment
delvh
left a comment
There was a problem hiding this comment.
Seems like your regex had three false positives.
| <div class="ui five wide column"> | ||
| <div class="ui card"> | ||
| <div id="profile-avatar" class="content gt-df"/> | ||
| <div id="profile-avatar" class="content gt-df"> |
Member
There was a problem hiding this comment.
Did the logic change here?
Looks a bit like it to me…
Contributor
Author
There was a problem hiding this comment.
It is right, I tested it.
Member
There was a problem hiding this comment.
The real closing </div> is in line 17.
Member
There was a problem hiding this comment.
And how has this worked previously?
Or has it always been wrong before?
Contributor
Author
There was a problem hiding this comment.
No, <div /> doesn't close.
<div />....</div> works like <div>....</div>
zeripath
pushed a commit
that referenced
this pull request
Mar 27, 2023
Follow #23748 Thanks to @delvh ---- And, fix the UI alignment by the way (adding some `gt-mr-xx`) Before:  After: 
zeripath
pushed a commit
to zeripath/gitea
that referenced
this pull request
Mar 27, 2023
…3751) Backport go-gitea#23751 Follow go-gitea#23748 Thanks to @delvh ---- And, fix the UI alignment by the way (adding some `gt-mr-xx`) Before:  After: 
techknowlogick
pushed a commit
that referenced
this pull request
Mar 27, 2023
Always respect the `setting.UI.ShowUserEmail` and `KeepEmailPrivate` setting. * It doesn't make sense to show user's own E-mail to themself. * Always hide the E-mail if KeepEmailPrivate=true, then the user could know how their profile page looks like for others. * Revert the `setting.UI.ShowUserEmail` change from #4981 . This setting is used to control the E-mail display, not only for the user list page. ps: the incorrect `<div .../>` tag on the profile page has been fixed by #23748 together, so this PR becomes simpler.
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Mar 27, 2023
Always respect the `setting.UI.ShowUserEmail` and `KeepEmailPrivate` setting. * It doesn't make sense to show user's own E-mail to themself. * Always hide the E-mail if KeepEmailPrivate=true, then the user could know how their profile page looks like for others. * Revert the `setting.UI.ShowUserEmail` change from go-gitea#4981 . This setting is used to control the E-mail display, not only for the user list page. ps: the incorrect `<div .../>` tag on the profile page has been fixed by go-gitea#23748 together, so this PR becomes simpler.
lunny
pushed a commit
that referenced
this pull request
Mar 27, 2023
Backport #23747 by @wxiaoguang Always respect the `setting.UI.ShowUserEmail` and `KeepEmailPrivate` setting. * It doesn't make sense to show user's own E-mail to themself. * Always hide the E-mail if KeepEmailPrivate=true, then the user could know how their profile page looks like for others. * Revert the `setting.UI.ShowUserEmail` change from #4981 . This setting is used to control the E-mail display, not only for the user list page. ps: the incorrect `<div .../>` tag on the profile page has been fixed by #23748 together, so this PR becomes simpler. Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 28, 2023
* upstream/main: Fix issue due date edit toggle bug (go-gitea#23723) Fix profile page email display, respect settings (go-gitea#23747) Update Gitea version in docs (go-gitea#23755) Fix SVG close tag, improve commit graph page UI alignment (go-gitea#23751) Remove incorrect HTML self close tag (go-gitea#23748) Refactor repo commit list (go-gitea#23690) Fix tags view (go-gitea#23243) Add commit info in action page (go-gitea#23210) Use GitHub Actions compatible globbing for `branches`, `tag`, `path` filter (go-gitea#22804)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HTML is not XML.