Added language as a filter to explore/repo_search #24212

snematoda · 2023-04-19T16:23:30Z

Added a new language filter beside the existing sort for repos in explore

JakobDev

I was already working on this and almost finished, but you were faster. I have left a few comments with the toughs I was facing during developing this.

templates/explore/repo_search.tmpl

routers/web/explore/repo.go

silverwind · 2023-04-21T20:07:20Z

Any screenshot?

snematoda · 2023-04-22T11:19:15Z

Any screenshot?

Sure!
Just updated the PR message

models/repo/repo_list.go

routers/web/explore/repo.go

lunny · 2023-04-23T09:45:38Z

I will send my LGTM now. But a further step is to use async menus with a search box because the programming languages may be very big on public websites.

JakobDev · 2023-04-23T11:04:12Z

But a further step is to use async menus with a search box because the programming languages may be very big on public websites

I think this should be done, before this is merged.

routers/web/explore/repo.go

snematoda · 2023-04-24T10:37:14Z

But a further step is to use async menus with a search box because the programming languages may be very big on public websites

I think this should be done, before this is merged.

Just added search

silverwind · 2023-04-24T11:04:31Z

I will send my LGTM now. But a further step is to use async menus with a search box because the programming languages may be very big on public websites.

Please define "big". The number after which to go async depends on the dropdown performance. I have other UIs where I don't consider pagination until 10k items. Test first how many items the dropdown can render performantly, and then decide whether pagination is worth it. How big can the language list get? Maybe 200?

snematoda · 2023-04-24T11:40:44Z

Test first how many items the dropdown can render performantly, and then decide whether pagination is worth it.

Well, I don't think I have the resources to test on even a moderately sized instance.

However initially, rendering .LanguagesColor (~500 items) directly from enry (without db calls) seemed fine

routers/api/v1/repo/languages.go

silverwind · 2023-08-21T21:41:27Z

@JakobDev looking good?

JakobDev · 2023-08-21T22:09:19Z

The API needs a little bit of improvement. If you want to get all languages for a User you need o load all Repos of that User and pass the IDs to /repos/languages. I think we should also add /user/{username}/languages and /org/{orgs}/languages to get the languages for a User/Org.

We need also tests for the API to make sure it keeps working as expected. If you don't know how to write tests, I can do that for you.

routers/api/v1/repo/languages.go

lafriks · 2023-08-21T22:18:40Z

models/repo/repo_list.go

+func GetPrimaryRepoLanguageList(ctx context.Context, repos RepositoryList) (LanguageStatList, error) {
+	languageList := make(LanguageStatList, 0)
+
+	q := db.GetEngine(ctx).


I don't think this will perform well in large instances.

Discussed at #24212 (comment)

Unsure what the ideal alternative would be

Maybe add a new table to store the languages and counts

Maybe add a new table to store the languages and counts

Hmm, might work for the global list but unsure how to filter them by the repo owner since a few databases do not support storing primitive types as an array. Might be possible to create yet another table containing a the list of owners but tbf I wonder if the benefits would be worth it at that point

snematoda · 2023-08-22T14:47:14Z

The API needs a little bit of improvement. If you want to get all languages for a User you need o load all Repos of that User and pass the IDs to /repos/languages. I think we should also add /user/{username}/languages and /org/{orgs}/languages to get the languages for a User/Org.

@JakobDev I have added a query param for the ownerId (ignored when repo ids are provided fn) ... felt it was easier than adding multiple api routes :P

We need also tests for the API to make sure it keeps working as expected. If you don't know how to write tests, I can do that for you.

Thank you! I have added in a minimal test fn

JakobDev · 2023-08-23T15:33:01Z

You should really add the routes I mentioned instead of using a query param. that would match the behaviour of the other routes together with a test for each. That's mostly copy and paste.

Thank you! I have added in a minimal test fn

You should also check if the values are correct to make sure this doesn't break in the future.

routers/api/v1/repo/languages.go

web_src/fomantic/build/semantic.css

modules/context/base.go

models/repo/repo_list.go

tests/integration/api_languages_test.go

lunny · 2024-01-25T13:29:31Z

@snematoda Can you send the PR again? I want to resolve the conflicts but made the PR broken.

silverwind added type/feature Completely new functionality. Can only be merged if feature freeze is not active. topic/ui Change the appearance of the Gitea UI labels Apr 19, 2023

silverwind added this to the 1.20.0 milestone Apr 19, 2023

JakobDev reviewed Apr 20, 2023

View reviewed changes

templates/explore/repo_search.tmpl Outdated Show resolved Hide resolved

routers/web/explore/repo.go Outdated Show resolved Hide resolved

GiteaBot added lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 20, 2023

pull-request-size bot added the size/M label Apr 22, 2023

lunny reviewed Apr 22, 2023

View reviewed changes

models/repo/repo_list.go Outdated Show resolved Hide resolved

lunny reviewed Apr 22, 2023

View reviewed changes

models/repo/repo_list.go Outdated Show resolved Hide resolved

lunny reviewed Apr 23, 2023

View reviewed changes

routers/web/explore/repo.go Outdated Show resolved Hide resolved

GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 23, 2023

yp05327 reviewed Apr 24, 2023

View reviewed changes

routers/web/explore/repo.go Outdated Show resolved Hide resolved

GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 24, 2023

silverwind added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. labels Apr 24, 2023

GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 24, 2023

silverwind added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. labels Apr 24, 2023

GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 24, 2023

silverwind mentioned this pull request Aug 21, 2023

add filter by author/assignee in /issues (#25979) #26643

Closed

silverwind reviewed Aug 21, 2023

View reviewed changes

routers/api/v1/repo/languages.go Outdated Show resolved Hide resolved

JakobDev reviewed Aug 21, 2023

View reviewed changes

routers/api/v1/repo/languages.go Outdated Show resolved Hide resolved

lafriks reviewed Aug 21, 2023

View reviewed changes

JakobDev reviewed Aug 23, 2023

View reviewed changes

routers/api/v1/repo/languages.go Outdated Show resolved Hide resolved

puni9869 reviewed Aug 27, 2023

View reviewed changes

web_src/fomantic/build/semantic.css Outdated Show resolved Hide resolved

puni9869 reviewed Aug 27, 2023

View reviewed changes

modules/context/base.go Outdated Show resolved Hide resolved

JakobDev reviewed Aug 28, 2023

View reviewed changes

models/repo/repo_list.go Outdated Show resolved Hide resolved

JakobDev reviewed Aug 28, 2023

View reviewed changes

tests/integration/api_languages_test.go Outdated Show resolved Hide resolved

lunny modified the milestones: 1.21.0, 1.22.0 Sep 21, 2023

github-actions bot added modifies/translation modifies/api This PR adds API routes or modifies them modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin modifies/frontend modifies/docs modifies/migrations modifies/internal labels Jan 25, 2024

lunny closed this Jan 25, 2024

lunny force-pushed the patch-1 branch from eb3054e to 3084c99 Compare January 25, 2024 13:28

pull-request-size bot removed the size/L label Jan 25, 2024

GiteaBot removed this from the 1.22.0 milestone Jan 25, 2024

pull-request-size bot added the size/XS label Jan 25, 2024

snematoda mentioned this pull request Feb 4, 2024

RE: Added language as a filter to explore/repo_search #29044

Open

github-actions bot locked as resolved and limited conversation to collaborators Mar 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added language as a filter to explore/repo_search #24212

Added language as a filter to explore/repo_search #24212

snematoda commented Apr 19, 2023 •

edited

Loading

JakobDev left a comment

silverwind commented Apr 21, 2023

snematoda commented Apr 22, 2023

lunny commented Apr 23, 2023

JakobDev commented Apr 23, 2023

snematoda commented Apr 24, 2023 •

edited

Loading

silverwind commented Apr 24, 2023 •

edited

Loading

snematoda commented Apr 24, 2023

silverwind commented Aug 21, 2023

JakobDev commented Aug 21, 2023

lafriks Aug 21, 2023 •

edited

Loading

snematoda Aug 22, 2023

lunny Aug 24, 2023

snematoda Aug 27, 2023

snematoda commented Aug 22, 2023

JakobDev commented Aug 23, 2023

lunny commented Jan 25, 2024

Added language as a filter to explore/repo_search #24212

Added language as a filter to explore/repo_search #24212

Conversation

snematoda commented Apr 19, 2023 • edited Loading

JakobDev left a comment

Choose a reason for hiding this comment

silverwind commented Apr 21, 2023

snematoda commented Apr 22, 2023

lunny commented Apr 23, 2023

JakobDev commented Apr 23, 2023

snematoda commented Apr 24, 2023 • edited Loading

silverwind commented Apr 24, 2023 • edited Loading

snematoda commented Apr 24, 2023

silverwind commented Aug 21, 2023

JakobDev commented Aug 21, 2023

lafriks Aug 21, 2023 • edited Loading

Choose a reason for hiding this comment

snematoda Aug 22, 2023

Choose a reason for hiding this comment

lunny Aug 24, 2023

Choose a reason for hiding this comment

snematoda Aug 27, 2023

Choose a reason for hiding this comment

snematoda commented Aug 22, 2023

JakobDev commented Aug 23, 2023

lunny commented Jan 25, 2024

snematoda commented Apr 19, 2023 •

edited

Loading

snematoda commented Apr 24, 2023 •

edited

Loading

silverwind commented Apr 24, 2023 •

edited

Loading

lafriks Aug 21, 2023 •

edited

Loading