Fix template function DateTime#24317
Merged
Merged
Conversation
GiteaBot
added
the
lgtm/need 2
wxiaoguang
force-pushed
the
fix-datetime
branch
from
2a92306 to
71dc657
Compare
lunny
approved these changes
Apr 25, 2023
GiteaBot
added
lgtm/need 1
yardenshoham
approved these changes
Apr 25, 2023
Member
yardenshoham
left a comment
yardenshoham
left a comment
There was a problem hiding this comment.
Thanks for this. I knew string as an input doesn't make much sense but I didn't know the internal Time/TimeStamp types very well. Can we drop DateFmtLong now?
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
Contributor
Author
I think I can try to introduce |
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 26, 2023
* giteaofficial/main: Fix broken clone script on an empty archived repo (go-gitea#24339) Improve RSS (go-gitea#24335) Automatically select the org when click create repo from org dashboard (go-gitea#24325) on schedule on schedule switch to use Actions from drone for cron (go-gitea#24314) [skip ci] Updated translations via Crowdin Restore bold on repolist (go-gitea#24337) Fix template function DateTime (go-gitea#24317) Fix incorrect CORS response in Http Git handler (go-gitea#24303) Updated upgrade script that is informing user that Gitea service has to be running in order to upgrade it (go-gitea#24260) Add tags list for repos whose release setting is disabled (go-gitea#23465) Refactor config provider (go-gitea#24245) Add RSS Feeds for branches and files (go-gitea#22719) Make SVG in dropdown menu have the same margin-right as IMG (go-gitea#24316) Respect the REGISTER_MANUAL_CONFIRM setting when registering via OIDC (go-gitea#24035)
techknowlogick
pushed a commit
that referenced
this pull request
Apr 26, 2023
After #24317 this function is only used in one place where it is not needed. I confirmed the timestamp still renders correctly Signed-off-by: Yarden Shoham <git@yardenshoham.com>
wxiaoguang
added
the
skip-changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, 500 error