Support configuration variables on Gitea Actions
#24404
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
silverwind
changed the title
configuration varibales on Gitea Actionsconfiguration variables on Gitea Actions
silverwind
added
type/feature
sillyguodong
changed the title
configuration variables on Gitea Actionsconfiguration variables on Gitea Actions
wxiaoguang
reviewed
May 9, 2023
lunny
reviewed
May 14, 2023
lunny
reviewed
May 14, 2023
routers/api/actions/runner/utils.go
Outdated
| log.Error("find variables of repo: %d, error: %v", task.Job.Run.RepoID, err) | ||
| } | ||
|
|
||
| // TODO: Env level |
There was a problem hiding this comment.
Will this be fixed in this PR? What did it mean?
There was a problem hiding this comment.
Environment is a separate module. It contains the feature of not only environment level variables but also protection rules and environment level secrets.
So i think the feature of Environment should be completed by a new PR.
Screenshot of environment configuration on github：
sillyguodong
force-pushed
the
feature/variables
branch
from
bcaba8b to
3db3d5d
Compare
3 tasks
|
Sorry for my mistake leads to commits cannot sync to this PR. |
silverwind
added a commit
that referenced
this pull request
Jun 20, 2023
Co-Author: @silverwind @wxiaoguang Replace: #24404 See: - [defining configuration variables for multiple workflows](https://docs.github.com/en/actions/learn-github-actions/variables#defining-configuration-variables-for-multiple-workflows) - [vars context](https://docs.github.com/en/actions/learn-github-actions/contexts#vars-context) Related to: - [x] protocol: https://gitea.com/gitea/actions-proto-def/pulls/7 - [x] act_runner: https://gitea.com/gitea/act_runner/pulls/157 - [x] act: https://gitea.com/gitea/act/pulls/43 #### Screenshoot Create Variable:   Workflow: ```yaml test_vars: runs-on: ubuntu-latest steps: - name: Print Custom Variables run: echo "${{ vars.test_key }}" - name: Try to print a non-exist var run: echo "${{ vars.NON_EXIST_VAR }}" ``` Actions Log:  --- This PR just implement the org / user (depends on the owner of the current repository) and repo level variables, The Environment level variables have not been implemented. Because [Environment](https://docs.github.com/en/actions/deployment/targeting-different-environments/using-environments-for-deployment#about-environments) is a module separate from `Actions`. Maybe it would be better to create a new PR to do it. --------- Co-authored-by: silverwind <[email protected]> Co-authored-by: wxiaoguang <[email protected]> Co-authored-by: Giteabot <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See:
Related to:
Screenshoot
Create Variable:
Workflow:
Actions Log:
This PR just implement the org and repo level variables, The Environment level variables have not been implemented.
Because
Environmentis a module separate fromActions. Maybe it would be better to create a new PR to do it.